[iov-cli] Add wait() function to repl #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Jul 20, 2018
| // yarn run ts-node wait-demo.ts | ||
|
|
||
| function wait<T>(promise: Promise<T>): T { | ||
| return require('deasync2').await(promise); |
There was a problem hiding this comment.
Would it make sense to do the require/import once at the top of the file and then just use it?
There was a problem hiding this comment.
Using it like this such that I can easily convert it into a single line command for the init file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create wait() as an alternative to the await keyword, that does not work with TypeScript in a repl.
We use deasync2 via Github because of bluelovers/deasync#1 and disable node warnings because of bluelovers/deasync#2.