Expose libp2p metrics and bandwidth stats for libp2p protocols #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
force-pushed
the
feat/libp2p-metrics
branch
from
fea03f5
to
6877160
Compare
With the following commit we are adding a new health/bandwidth endpoint which reports metrics stats coming from libp2p's bandwidth counter. Unfortunately, we need to pass around the bandwidth counter in some way, so wiring these stats requires providing the reporter during NewCluster() etc. When set to nil no stats will be returned (even though it still happens as it goes into the libp2p host configuration by default).
This adds support for health/bandwidth to the restapi.Client and ipfs-cluster-ctl.
hsanjuan
force-pushed
the
feat/libp2p-metrics
branch
from
6877160
to
d0dad4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two parts:
ipfs-cluster-ctl health bandwidthcan be used to display the stats in a prettified way.