fix!: use Node16 module resolution #1434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support the `"types"` field in `package.json` to support modules that no longer have a root `"types"` field.
achingbrain
changed the title
achingbrain
added a commit
that referenced
this pull request
Jan 12, 2024
These deps don't work with `Node16` module resolution and PRs to fix this have been open for ages. Unblocks #1434
achingbrain
added a commit
that referenced
this pull request
Jan 12, 2024
These deps don't work with `Node16` module resolution and PRs to fix this have been open for ages. Unblocks #1434
SgtPooki
approved these changes
Apr 3, 2024
|
We need to test this thoroughly before merging - every dep needs a types entry for every export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the
"types"field inpackage.jsonto support modules that no longer have a root"types"field.BREAKING CHANGE: Node16 module resolution ignores "types" and "typesVersions" in the
package.jsonroot when an exports map is found so requires "types" on every exports map entry instead