Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude stderr output if only stdout is passed in env #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Bidon15
Copy link

@Bidon15 Bidon15 commented Aug 22, 2022

If the user only wants to see the log output to be in stdout with no stderr, then this can be a fix without making GOLOG_FILE = /dev/null

@welcome
Copy link

welcome bot commented Aug 22, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

setup.go Outdated Show resolved Hide resolved
@BigLep BigLep requested a review from Jorropo August 26, 2022 15:27
@BigLep BigLep linked an issue Aug 26, 2022 that may be closed by this pull request
@BigLep BigLep added this to the Best Effort Track milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

Exclude cfg.Stderr if only Stdout is provided in env var
2 participants