Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: offline error page #920

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Sep 10, 2020

About

This PR adds a more friendly and useful error page when either user's custom gateway is offline, or user tries to load a DNSLink-enabled site from an unavailable remote host.

Closes #806.

To do:

  • Remove some unneeded resources in this landing page's directory
  • Move text into i18n keys once agreed upon
  • Wire up buttons, error-check condition, and display for window.location.hash

image

image

@jessicaschilling
Copy link
Contributor Author

jessicaschilling commented Sep 10, 2020

@lidel - No need to look at code for this yet, just wanted to confirm this direction with you before moving the text into i18n keys. Note that the explanatory text is intended to change depending on error context, so a wired-up version of this would only display one text-plus-button(s) combo (either "Your custom gateway ..." or "You tried to load ..."). Do you mind a quick look? Thanks 😊

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction looks great, love the icon, thank you 🙏

Sidenote: this screen will be useful not only for recovering when local gateway is down. We will have two types of errors:

  • Local gateway is offline
  • Remote server error
    • if DNSLink is present and original server is down, Companion is able to recover by loading DNSLink website from the local gateway (example below).

add-on/src/landing-pages/offline/page.js Outdated Show resolved Hide resolved
@jessicaschilling
Copy link
Contributor Author

@lidel -- I think this is ready for you to wire up at your leisure. CI is failing due to missing manifest.json but looks like that's intentionally excluded? Let me know if there's anything else I can do.

@lidel lidel marked this pull request as draft May 6, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS-aware error page: improve UX when gateway is offline
2 participants