Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: run all unit and e2e tests by default #1373

Merged
merged 1 commit into from
Jan 8, 2020
Merged

refactor: run all unit and e2e tests by default #1373

merged 1 commit into from
Jan 8, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 8, 2020 •
edited

This PR moves interactive unit tests to test:unit,
and makes generic npm test run both unit (react) and e2e (added in #1353) test suites.

Motivation

This will enable us to merge ipfs/js-ipfs#2706 and test js-ipfs against ipfs-webui E2E with regular aegir test-external:

    - stage: test
      name: external - ipfs-webui
      script:
        - E2E_IPFSD_TYPE=js npm run test:external -- ipfs-webui https://github.com/ipfs-shipyard/ipfs-webui.git

cc @hugomrdias @autonome

@lidel
refactor: run e2e by default
825e0f2 
This refactor moves interactive unit tests to `test:unit`, and makes
generic `test` run both unit and end to end tests.

This enables ipfs-webui to be tested E2E via `aegir test-external`
@lidel lidel mentioned this pull request Jan 8, 2020
Merged
3 tasks
@lidel lidel merged commit e98e54f into master Jan 8, 2020
@lidel lidel deleted the feat/e2e-during-regular-tests branch January 8, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomrdias hugomrdias hugomrdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lidel @hugomrdias