Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Update package.json #1962

Closed
wants to merge 1 commit into from
Closed

Conversation

josselinchevalay
Copy link
Contributor

@josselinchevalay josselinchevalay commented Mar 25, 2019

hello with this version of electron seems works on my system. and seems resolve issue with exemple not works

hello with this version of electron seems works on my system. and seems resolve issue with ipfs#1897
@alanshaw
Copy link
Member

With JS IPFS master and electron 4 + electron-rebuild 1.8 I get the following error:

Screenshot 2019-03-26 at 09 48 05

cc @hugomrdias

@josselinchevalay
Copy link
Contributor Author

https://github.com/moxystudio/node-proper-lockfile/blob/master/lib/lockfile.js#L121 i find in ths code but i not sure to understand why 🤔

@josselinchevalay
Copy link
Contributor Author

issue created : moxystudio/node-proper-lockfile#84

@elantion
Copy link

elantion commented Apr 2, 2019

I got same error with you, Alan. I try to find out why, but no clue at all.

@alanshaw
Copy link
Member

alanshaw commented Apr 4, 2019

I'm closing this since it doesn't fix the issue and I can't merge it as is.

@alanshaw alanshaw closed this Apr 4, 2019
@elantion
Copy link

elantion commented Apr 4, 2019

Actually, it did solve the object spread issue because electron 2.x is too old, but not the lock file issue. The lock file issue solved in proper-lockfile package, see moxystudio/node-proper-lockfile#87. Maybe you should merge it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants