Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_enter_eventloop #1084

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Remove test_enter_eventloop #1084

merged 2 commits into from
Feb 3, 2023

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Jan 31, 2023

test_enter_eventloop does the following:

kernel.eventloop = asyncio.get_running_loop()

The only place where kernelbase.eventloop is used is here, and it seems to call the event loop. But an asyncio event loop is not callable, or am I missing something?
I inserted an error just before the call to the event loop, and the test still passes, so what does this test do?
Should we remove it?

@davidbrochart davidbrochart changed the title Test enter event-loop Remove test_enter_eventloop Feb 1, 2023
@davidbrochart
Copy link
Collaborator Author

This last commit removes test_enter_eventloop.
If someone is against it, please speak up. Otherwise, I will merge.

@blink1073
Copy link
Member

That test was there to add more coverage in enter_eventloop, I'm fine to remove it.

@davidbrochart davidbrochart merged commit 1d67450 into main Feb 3, 2023
@davidbrochart davidbrochart deleted the test_enter_eventloop branch February 3, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants