Bugfix: binary stdout/stderr handling #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_watch_pipe_fd() decodes the incoming data from the pipe using str::decode(). By default this passed the 'strict' errors flag to the unicode engine. However, if the pipe command returns binary data this will through a UnicodeError exception. We change the code to explicitly pass the 'replace' errors flag, which will replace the output with output that can be displayed on screen. We also specify the buffer size as a constant so it can be changed for edge cases where the task pipes a lot of output/error text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_watch_pipe_fd()decodes the incoming data from the pipe using str::decode(). By default this passed thestricterrors flag to the unicode engine. However, if the pipe command returns binary data this will through aUnicodeErrorexception.We change the code to explicitly pass the
replaceerrors flag, which will replace the output with output that can be displayed on screen.We also specify the buffer size as a constant so it can be changed for edge cases where the task pipes a lot of output/error text.