Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_abort_queues is no longer async #942

Merged
merged 1 commit into from
Aug 8, 2022
Merged

_abort_queues is no longer async #942

merged 1 commit into from
Aug 8, 2022

Conversation

rhelmot
Copy link
Contributor

@rhelmot rhelmot commented May 27, 2022

Resolves some warnings while using qtconsole!

@ccordoba12
Copy link
Member

What warnings?

@rhelmot
Copy link
Contributor Author

rhelmot commented May 27, 2022

foo
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Input In [1], in <cell line: 1>()
----> 1 foo

NameError: name 'foo' is not defined
/home/audrey/.virtualenvs/angr-c/lib/python3.8/site-packages/ipykernel/kernelbase.py:751: RuntimeWarning: coroutine 'InProcessKernel._abort_queues' was never awaited
  self._abort_queues()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

@minrk minrk added the bug label Jun 14, 2022
@rayosborn
Copy link
Contributor

I was about to create an issue on this topic when I noticed this PR. Is there any reason it can't be merged now? I can confirm that the suggested change fixes exception handling in my use of the QtInProcessKernelManager. I think there have been four releases since this was posted.

@blink1073
Copy link
Member

Sounds reasonable, thanks for the extra confirmation @rayosborn.

@rayosborn
Copy link
Contributor

Does anyone know if a new version will be released soon? I am about to release a new version of NeXpy, which currently would have to require ipykernel v6.8.0, but I can hold off for a few days if a release is imminent.

@blink1073
Copy link
Member

Thanks for the ping @rayosborn, we try not to release on a Friday, but I will make a release on Monday.

@rayosborn
Copy link
Contributor

That's great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants