Switch CLI argument parsing to clap v3
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #298, switches command-line argument processing from `gumdrop` to `clap` v3.0.0-beta.4. This release of `clap`, despite still being beta, has moved many of the warnings around the stability of the API. They are also cutting scope of an initial release upstream, which are good signs that they will get to a stable release soon.
This was referenced Oct 6, 2021
Closed
|
Are you planning to release this as a new |
|
Yep! Will cut it shortly |
This was referenced Oct 6, 2021
Merged
Closed
|
Released as v0.6.0-pre.2 |
This was referenced Feb 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #298, switches command-line argument processing from
gumdroptoclapv3.0.0-beta.4.This release of
clap, despite still being beta, has moved many of the warnings around the stability of the API. They are also cutting scope of an initial release upstream, which are good signs that they will get to a stable release soon.This PR builds upon @rsdy's initial work in #479.