Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TSLint with ESLint #51

Closed
2 tasks done
iquabius opened this issue Jan 19, 2019 · 1 comment
Closed
2 tasks done

Replace TSLint with ESLint #51

iquabius opened this issue Jan 19, 2019 · 1 comment
Labels
prio-mid Tarefas de prioridade média que podem ser feitas quando não tiver tarefas de prioridade alta tooling O problema envolve o sistema de compilação, linting, ferramentas de teste...
Projects
Tooling
Milestone
w05

Comments

@iquabius
Copy link
Owner

iquabius commented Jan 19, 2019 •
edited

The future of TypeScript on ESLint (Jan 2019)

Example project: eslint-config-react-native-wcandillon

babel-eslint limitations

See:

Use babel-eslint to lint TypeScript with ESLint

We should compile API code with babel as well before we continue with this. Currently we're using 'ts-node' for dev env and tsc from 'typescript'. This is actually not a good idea. See:

You’ll get a more fluent TDD experience (when using ts-jest) since files will be type-checked at the same time they’re compiled and ran.

Relacionado a #95.
@iquabius iquabius created this issue from a note in Tooling (To do) Jan 19, 2019
@iquabius iquabius added prio-mid Tarefas de prioridade média que podem ser feitas quando não tiver tarefas de prioridade alta tooling O problema envolve o sistema de compilação, linting, ferramentas de teste... labels Jan 19, 2019
@iquabius iquabius added this to the w04 milestone Jan 24, 2019
@iquabius iquabius moved this from To do to In progress in Tooling Jan 25, 2019
@iquabius iquabius moved this from In progress to To do in Tooling Jan 25, 2019
@iquabius iquabius mentioned this issue Jan 25, 2019
Open
@iquabius iquabius modified the milestones: w04, w05 Jan 25, 2019
@lydell
Copy link

lydell commented Jan 26, 2019

eslint-config-prettier v4.0.0 is now released!

@iquabius iquabius moved this from To do to In progress in Tooling Jan 27, 2019
@iquabius iquabius mentioned this issue Jan 28, 2019
Merged
Tooling automation moved this from In progress to Done Jan 28, 2019
iquabius added a commit that referenced this issue Jan 28, 2019
@iquabius
Set up ESLint with @typescript-eslint packages (#118)
7a04db9 
[@typescript-eslint](https://github.com/typescript-eslint/typescript-eslint) seems to be the way to go since it actually uses TypeScript under the hood. The alternative is Babel, which "parses and strips the type information, you still need the TypeScript compiler running if you want type checking." see [babel/babel-eslint#63](babel/babel-eslint#663 (comment))

[The future of TypeScript on ESLint (Jan 2019)](https://eslint.org/blog/2019/01/future-typescript-eslint)

Closes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-mid Tarefas de prioridade média que podem ser feitas quando não tiver tarefas de prioridade alta tooling O problema envolve o sistema de compilação, linting, ferramentas de teste...
Projects
Tooling
  
Done
Milestone
w05
Development

No branches or pull requests
2 participants
@lydell @iquabius