Set up ESLint with @typescript-eslint packages #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need this since we're extending the recommend config: https://github.com/yannickcr/eslint-plugin-react/blob/master/index.js#L122
We use .js for some config files, but that's it. .jsx is not used.
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage ? 24.71%
=========================================
Files ? 106
Lines ? 1323
Branches ? 183
=========================================
Hits ? 327
Misses ? 996
Partials ? 0
Continue to review full report at Codecov.
|
This pattern should be discouraged.
The autoFocus prop should be avoided as it can cause accessibility problems
"Enforce onClick is accompanied by at least one of the following: onKeyUp, onKeyDown, onKeyPress. Coding for the keyboard is important for users with physical disabilities who cannot use a mouse, AT compatibility, and screenreader users." https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@typescript-eslint seems to be the way to go since it actually uses TypeScript under the hood. The alternative is Babel, which "parses and strips the type information, you still need the TypeScript compiler running if you want type checking." see babel/babel-eslint#63
The future of TypeScript on ESLint (Jan 2019)
Closes #51