don't try to chown /bin/sh in test on Linux

isaacs · Jul 3, 2019 · f318a5e · f318a5e
1 parent b06e7ef
commit f318a5e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/test/symlink-sync.js b/test/symlink-sync.js
@@ -27,7 +27,8 @@ exec("id", function (code, output) {
   rimraf("dir", function (er) {
     if (er) throw er
     fs.mkdirSync("dir")
-    fs.symlinkSync("/bin/sh", "dir/sh-link")
+    fs.writeFileSync("dir/sh")
+    fs.symlinkSync("./sh", "dir/sh-link")
     runTest()
   })
 })

diff --git a/test/symlink.js b/test/symlink.js
@@ -2,6 +2,9 @@ if (!process.getuid || !process.getgid) {
   throw new Error("Tests require getuid/getgid support")
 }
 
+var skip = process.platform === 'darwin' ? false
+  : 'linux and windows do not treat links as separate fs objects'
+
 var curUid = +process.getuid()
 , curGid = +process.getgid()
 , chownr = require("../")
@@ -28,7 +31,8 @@ exec("id", function (code, output) {
   rimraf("dir", function (er) {
     if (er) throw er
     fs.mkdirSync("dir")
-    fs.symlinkSync("/bin/sh", "dir/sh-link")
+    fs.writeFileSync("dir/sh")
+    fs.symlinkSync("./sh", "dir/sh-link")
     runTest()
   })
 })
@@ -48,8 +52,8 @@ function runTest () {
         t.ifError(er)
         return t.end()
       }
-      t.notEqual(st.uid, curUid, "uid not should be " + curUid)
-      t.notEqual(st.gid, groups[0], "gid not should be "+groups[0])
+      t.notEqual(st.uid, curUid, "uid", {skip})
+      t.notEqual(st.gid, groups[0], "gid", {skip})
       t.end()
     })
   })
@@ -62,4 +66,3 @@ function runTest () {
     })
   })
 }
-