Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unused modules / variables and circular references #374

Closed
wants to merge 1 commit into from

Conversation

adrielcodeco
Copy link

the code "var Glob = require ('./ glob.js'). Glob" in sync.js is a circular reference
and others are not used

@adrielcodeco
Copy link
Author

anybody can help here?

my changes do not impact to cause this error
travis build successfully, but appveyor failed with this error:

npm install
C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js:82
let notifier = require('update-notifier')({pkg})
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:387:25)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Function.Module.runMain (module.js:447:10)
at startup (node.js:148:18)
at node.js:405:3

Copy link

@jimmywarting jimmywarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmywarting

This comment has been minimized.

@kuraga kuraga mentioned this pull request Dec 8, 2019
@xup6m6fu04
Copy link

@isaacs , please merge

@jamesej
Copy link

jamesej commented Nov 17, 2021

A request for someone to fix and merge this as I actually get a runtime error in a setup with Rollup and Typescript which is caused by the circular dependency this resolves.

eventualbuddha added a commit to eventualbuddha/node-glob that referenced this pull request May 23, 2022
Another pass at isaacs#374, fixing issues with certain bundlers like Rollup (see isaacs#365).
@isaacs
Copy link
Owner

isaacs commented Mar 1, 2023

No longer an issue in v9.

@isaacs isaacs closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants