feat: add supportWindowsPaths option #476
Conversation
nicolas377
force-pushed
the
support-windows-paths
branch
from
00b222a
to
4befced
Compare
| self.supportWindowsPaths = !!options.supportWindowsPaths | ||
| if (self.supportWindowsPaths) { | ||
| options.pathSep = undefined | ||
| pattern = pattern.replace(/\\/g, "/") |
There was a problem hiding this comment.
Cool things I found out, /\\/g is 105% faster than /\\|\//g.
There was a problem hiding this comment.
So instead of doing 1000/ms you can do 2000? Not trying to be too snarky, but it's a one-time action at initialization, and wildly fast, even in a benchmark with 2000 path portions and a mix of \ and /. Even if it was 10,000x faster, even if it was somehow able to magically do it in 0 CPU cycles, it's still only saving you 0.0001% of the overall time.
There was a problem hiding this comment.
Of course, if it was actually possible to do in 0 CPU cycles, we'd be better off spending our time figuring how how to express all compute problems in terms of slash replacement, and win the turing prize for solving P=NP lol
There was a problem hiding this comment.
I know that it's a very minor improvement in the grand scheme of things, it just seemed pretty cool to me.
|
This landed as |
This is the second and last part of the implementation of #468. The PR implements the supportWindowsPaths option, which is intended to be a flip-on switch for automatic backslash coercion.
closes #468