fix(types): re-export some stuff from path-scurry #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(It looks like e.g., |
|
CI failing on main branch |
|
This also wants |
|
Ah, yeah, some windows path issues. |
boneskull
force-pushed
the
boneskull/re-export-path-scurry
branch
from
03cc59c
to
0a09db8
Compare
This re-exports types that are accessible via the `Path` objects sometimes returned by `glob`. Types within `path-scurry` consumed only by members tagged `@internal` are not re-exported. PR-URL: isaacs#553 Credit: @boneskull Close: isaacs#553 Reviewed-by: @isaacs
isaacs
force-pushed
the
boneskull/re-export-path-scurry
branch
from
0a09db8
to
8d9f488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-exports types that are accessible via the
Pathobjects sometimes returned byglob.Types within
path-scurryconsumed only by members tagged@internalare not re-exported.Closes #551.
So, I didn't want to re-export everything, because a) you have to be explicit about what to re-export in TypeScript v4.9.5 using the
export type fromsyntax, so I couldn't get away with it easily, and b) some portion of the exports frompath-scurrylook like they're only needed for consumers writing subclasses that extendPathBase.