Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node:-prefixed requires for builtins #581

Closed
wants to merge 1 commit into from

Conversation

sgammon
Copy link
Contributor

@sgammon sgammon commented Mar 31, 2024

Fixes and closes #580 by switching to node:- prefixed requires for Node API builtins.

Will need releases for minipass and path-scurry, PRs for these are noted below.

Related issues:

Peer PRs:

Fixes and closes isaacs#580 by switching to `node:`-
prefixed requires for Node API builtins.

Will need releases for `minipass` and `path-scurry`, PRs for these
are noted below.

Relates to:
- isaacs/path-scurry#17
- isaacs/minipass#55

Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon added a commit to sgammon/hashlock that referenced this pull request Mar 31, 2024
- feat: support all popular js runtimes
  - patches for `glob`, `minipass`, and `path-scurry`
  - upstream prs (listed below)
  - test entrypoint commands
- test: add test entrypoints for each major runtime
- test: add scripts to test entrypoint with each major runtime
- chore: sync lockfiles

Related Issues
- isaacs/node-glob#580
- isaacs/path-scurry#16
- isaacs/minipass#54
- tj/commander.js#2169

Upstream PRs
- isaacs/node-glob#581
- isaacs/minipass#55
- isaacs/path-scurry#17
- tj/commander.js#2170

Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon added a commit to sgammon/hashlock that referenced this pull request Mar 31, 2024
- feat: support all popular js runtimes
  - patches for `glob`, `minipass`, and `path-scurry`
  - upstream prs (listed below)
  - test entrypoint commands
- test: add test entrypoints for each major runtime
- test: add scripts to test entrypoint with each major runtime
- chore: sync lockfiles

Related Issues
- isaacs/node-glob#580
- isaacs/path-scurry#16
- isaacs/minipass#54
- tj/commander.js#2169

Upstream PRs
- isaacs/node-glob#581
- isaacs/minipass#55
- isaacs/path-scurry#17
- tj/commander.js#2170

Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon added a commit to sgammon/hashlock that referenced this pull request Mar 31, 2024
- feat: support all popular js runtimes
  - patches for `glob`, `minipass`, and `path-scurry`
  - upstream prs (listed below)
  - test entrypoint commands
- test: add test entrypoints for each major runtime
- test: add scripts to test entrypoint with each major runtime
- chore: sync lockfiles

Related Issues
- isaacs/node-glob#580
- isaacs/path-scurry#16
- isaacs/minipass#54
- tj/commander.js#2169

Upstream PRs
- isaacs/node-glob#581
- isaacs/minipass#55
- isaacs/path-scurry#17
- tj/commander.js#2170

Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon added a commit to sgammon/hashlock that referenced this pull request Mar 31, 2024
* feat: support all runtimes

- feat: support all popular js runtimes
  - patches for `glob`, `minipass`, and `path-scurry`
  - upstream prs (listed below)
  - test entrypoint commands
- test: add test entrypoints for each major runtime
- test: add scripts to test entrypoint with each major runtime
- chore: sync lockfiles

Related Issues
- isaacs/node-glob#580
- isaacs/path-scurry#16
- isaacs/minipass#54
- tj/commander.js#2169

Upstream PRs
- isaacs/node-glob#581
- isaacs/minipass#55
- isaacs/path-scurry#17
- tj/commander.js#2170

Signed-off-by: Sam Gammon <sam@elide.dev>

* chore: version bump → `1.0.3`

Signed-off-by: Sam Gammon <sam@elide.ventures>

---------

Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.ventures>
@isaacs isaacs closed this in 435d1f7 May 9, 2024
@isaacs
Copy link
Owner

isaacs commented May 9, 2024

Thanks! Got this one and path-scurry and minipass landed and pushed to npm.

@sgammon
Copy link
Contributor Author

sgammon commented May 20, 2024

Thank you @isaacs! Much appreciated 🙏

@isaacs
Copy link
Owner

isaacs commented Jun 7, 2024

Omg this has caused a flood of jest users reporting that node:path isn't a valid module. Jest issue, seems to already be fixed, but just funny. There's no way to please everyone lol

@sgammon
Copy link
Contributor Author

sgammon commented Jun 7, 2024

Omg 🤦‍♂️ sorry for the mess. And thank you for merging. We are using glob effectively now on Deno.

No comment on how Deno broke Node here and they were both invented by the same person. 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neutral JavaScript runtime support (Deno, Bun, etc)
2 participants