Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the noChmod option #270

Merged
merged 6 commits into from Jan 7, 2021
Merged

Add the noChmod option #270

merged 6 commits into from Jan 7, 2021

Commits on Jan 7, 2021

  1. test: provide more garbagey gzip data for zlib fail test

    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    0f1211f View commit details
    Browse the repository at this point in the history

  2. actions: turn on core.longpaths for windows

    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    e753c9d View commit details
    Browse the repository at this point in the history

  3. always use LF line endings for test fixtures 

    Otherwise all the tests fail
    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ad43c86 View commit details
    Browse the repository at this point in the history

  4. ci: turn off windows tests for now

    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    bfa1f24 View commit details
    Browse the repository at this point in the history

  5. Skip known-bad test on old Node.js versions

    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    73ec0f7 View commit details
    Browse the repository at this point in the history

  6. Add the noChmod option 

    This allows a way to suppress the call to process.umask() while
still being as compliant as possible with the modes as defined
in the tarball entries.

Re: npm/cli#1103

PR-URL: #270
Credit: @isaacs
Close: #270
Reviewed-by: @ruyadorno
    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2d83d5b View commit details
    Browse the repository at this point in the history