Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Export tshy functions #52

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

svallory
Copy link

I'm not sure if this is something that aligns with your vision for the project, but I wanted this for myself. So I did it anyway, and I'm sending a pull request. Do with it whatever you want, no hurt feelings if this is not the direction you want to go.

Goal

To export tshy functions as a set of tasks that can be used to create custom build processes.

What I did

  • exported most (if not all) of tshy functions that encapsulate a build step, task, validation, or utility
  • Removed side effects from imports (including from index)
  • Created cli.ts that simply imports index and runs it
  • Added a new "./tasks" to the package exports
  • documented a lot of functions since they are now exported
  • Fixed tests broken by the removal of side effects

All that said, I tried to follow the existing style and to minimize code changes

@isaacs
Copy link
Owner

isaacs commented Mar 12, 2024

Wow, this is big lol

I'm not opposed in principle, but this'll take a minute to review. Appreciate your patience, I'll get to it as soon as I can.

@svallory
Copy link
Author

Wow, this is big lol

I'm not opposed in principle, but this'll take a minute to review. Appreciate your patience, I'll get to it as soon as I can.

Don't worry about it. I know there are a LOT of changes, but you'll soon see most of them are minimal changes. Some are just documentation, in many files I just added a named export of the default export. In any case, take your time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants