Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) add gzip size compression report #3400

Merged
merged 6 commits into from Nov 14, 2021

Conversation

bradleymackey
Copy link
Contributor

@bradleymackey bradleymackey commented Nov 13, 2021

This will report the gzip'd size of the CDN build output on every pull request, being run via GitHub actions.
Currently is applied to all Javascript output files.

Changes

Checklist

  • Markup tests not needed
  • Updated the changelog at CHANGES.md

This will report the gzip'd size of the CDN build output on every pull
request, being run via GitHub actions.
@bradleymackey bradleymackey changed the title (chore) add gzip compression action (chore) add gzip size compression report Nov 13, 2021
@joshgoebel
Copy link
Member

Can we have just a list vs wildcard? I think what we'd want indivdually:

  • /*.min.js
  • /es/*.min.js

And perhaps also (and only if the wildcard is aggregated):

  • /languages/*.min.js
  • /es/languages/*.min.js

Thoughts?

@bradleymackey
Copy link
Contributor Author

bradleymackey commented Nov 14, 2021

I think that can be done with the following wildcard: ./build/{*.min.js,es/*.min.js,languages/*.min.js,es/languages/*.min.js}.

But yes, sensible I think to only run the size of the minified files.

@bradleymackey
Copy link
Contributor Author

Yep it seems to work. See here for example.

@joshgoebel joshgoebel merged commit ef45496 into highlightjs:main Nov 14, 2021
@bradleymackey bradleymackey mentioned this pull request Aug 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add reporting the size of build changes on PRs
2 participants