New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new report - member registrations #2492
base: 2.9
Are you sure you want to change the base?
new report - member registrations #2492
Conversation
Unfortunately, I get an error message when trying this locally:
Since I'm running MySQL 5.7 (MAMP on macOS), it could be that |
Yes you are right! The window functions (sum in that case) are new in Version 8. But 5.7 has reached EOL. Should we support that version futhermore? How do you handle the base requirements for Isotope? Can they only be updated with a new major version of Isotope? |
Well we cannot require a minimum version of MySQL (technically, on a Composer level). And Contao perfectly supports MySQL 5.7. So it would be a PITA to have a different dependency. Appart from the fact that my default hoster still has 5.7 (will be changed early next year) 😅 |
Ok, I see! I will try an alternative query. |
I removed the window function and solved it via code. I think it is a good alternative. Now the code compatible to MySQL 5.x. |
system/modules/isotope_reports/library/Isotope/Report/MembersRegistration.php
Outdated
Show resolved
Hide resolved
I tried this PR locally. But (probably) because I did not have any registration/member data, I got an empty page and an error in apexchart I guess there's a problem somewhere if the data/row is empty? |
Hi, I tried it without members / member data, but I cannot reproduce the error. I need more information about this. |
@aschempp I think now is fine and ready to merge? |
I'm sorry, I don't know what I'm doing wrong. I tried it again, but nothing changed. As you can see in the previous screenshot, I don't even have the same columns in the HTML table. Are you sure you pushed all changes? |
This reverts commit d09bd0f.
I have found the problem. The language keys in the English file was wrong. |
Add new report member registrations using new apexcharts library.