WIP: Users #261
WIP: Users #261
Conversation
…the appearance of their comments
# Conflicts: # isso/js/app/isso.js # isso/views/comments.py
|
This is a pretty neat solution, I'll need to review it more thoroughly. I don't like the user management in Isso, it should be solved by $framework a level above (which may provide pluggable user management, whatever. Not a realm of Isso IMHO). |
|
Yeah, the real deal would be adding an extensible user support, where the current anon system is just the "default provider" or something. I can also see how any user system would detract from the KISS style of this package. However, the inability to stylize and protect my own comments (which is expected behavior in any commenting system) was a deal breaker for me. So I added this simple thing for my own purposes. |
|
Any update on this? Styling mod comments and preventing impersonation is a really useful feature. |
| */ | ||
| this.on = function(type, listener, prevent) { | ||
| if (Array.isArray(type)) { | ||
| var that = this; | ||
| type.forEach(function (type) { |
There was a problem hiding this comment.
Shouldn't a different var name be used for the internally-scoped type? Even if just for clarity...
|
This is really nice, love the additional error highlighting, that it something I thought was missing. And the user system is so simple, I don't think there is a need for a full fledged framework user system. These are must have changes! |
Add a limited support for user accounts. A way for the site owner to:
For majority of posters, everything works the same as before.
See docs and configuration comments for more details.
TODO-s and remarks: