Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around write-file-atomic Windows EPERM issue #15

Merged
merged 2 commits into from
May 17, 2019

Conversation

coreyfarrell
Copy link
Member

Fixes #14


Going to wait for more feedback from @ehmicky to verify this resolves the issue before I consider merging. Just posting the PR so it becomes visible to others in case someone objects to using a retry cycle. My thinking is that caching-transform success implies that the cache file has been successfully created.

@coveralls
Copy link

coveralls commented May 11, 2019

Pull Request Test Coverage Report for Build 61

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 58: 0.0%
Covered Lines: 50
Relevant Lines: 50

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 11, 2019

Pull Request Test Coverage Report for Build 63

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 58: 0.0%
Covered Lines: 50
Relevant Lines: 50

💛 - Coveralls

@coreyfarrell
Copy link
Member Author

@ehmicky has stated that this fixes testing on Windows. Anyone have feelings for/against this approach to fixing the issue? @bcoe @JaKXz?

@bcoe
Copy link
Member

bcoe commented May 16, 2019

@coreyfarrell this is definitely a little icky 😄

I'll 👍, but is there a tracking issue on the Node.js project for this regression?

@coreyfarrell
Copy link
Member Author

To my knowledge it's not a node.js regression. See npm/write-file-atomic#28.

index.js Show resolved Hide resolved
@coreyfarrell coreyfarrell merged commit 1689877 into master May 17, 2019
@JaKXz JaKXz deleted the unbreak-windows branch May 17, 2019 19:50
@coreyfarrell coreyfarrell restored the unbreak-windows branch May 17, 2019 23:10
@coreyfarrell
Copy link
Member Author

coreyfarrell commented May 17, 2019

@JaKXz I'm leaving the unbreak-windows branch in place for now, it looks like @ehmicky is installing from that branch.

@ehmicky please point your package.json directly to 1689877 (the commit merged to master for this PR). At some point the unbreak-windows branch will be deleted. Edit: be sure to point at the specific SHA and not the master branch. At some point soon and without warning master will get a version bump and npm will not allow the bumped version to be used by nyc@14.

@ehmicky
Copy link

ehmicky commented May 18, 2019

Thanks for checking it! I've changed the reference to point to the commit hash, you can now safely remove the unbreak-windows branch. It's not used in production by anyone anymore.

@coreyfarrell coreyfarrell deleted the unbreak-windows branch May 18, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement work-around for Windows EPERM issue
5 participants