fix: add placeholder to fix Implicit Else (#679)

istanbuljs · Jul 13, 2022 · 0516f51 · 0516f51
1 parent c7693d4
commit 0516f51
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/packages/istanbul-reports/lib/html/annotator.js b/packages/istanbul-reports/lib/html/annotator.js
@@ -142,6 +142,23 @@ function annotateBranches(fileCoverage, structuredText) {
         // only highlight if partial branches are missing or if there is a
         // single uncovered branch.
         if (sumCount > 0 || (sumCount === 0 && branchArray.length === 1)) {
+            // Need to recover the metaArray placeholder item to count an implicit else
+            if (
+                // Check if the branch is a conditional if branch.
+                branchMeta[branchName].type === 'if' &&
+                // Check if the branch has an implicit else.
+                branchArray.length === 2 &&
+                // Check if the implicit else branch is unnacounted for.
+                metaArray.length === 1 &&
+                // Check if the implicit else branch is uncovered.
+                branchArray[1] === 0
+            ) {
+                metaArray[1] = {
+                    start: {},
+                    end: {}
+                };
+            }
+
             for (
                 i = 0;
                 i < branchArray.length && i < metaArray.length;

diff --git a/packages/istanbul-reports/test/fixtures/github-649.json b/packages/istanbul-reports/test/fixtures/github-649.json
@@ -100,11 +100,6 @@
             "line": 6,
             "column": 5
           }
-        }, {
-          "start": {
-          },
-          "end": {
-          }
         }
       ],
       "line": 4