Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add placeholder to fix Implicit Else #679

Merged
merged 5 commits into from Jul 13, 2022
Merged

Conversation

adrian-burlacu-software
Copy link
Contributor

@adrian-burlacu-software adrian-burlacu-software commented Apr 1, 2022

@bcoe
While implicit else reporting was fixed in pull #663, it no longer aligns to the instrumented API. Where I previously updated that to provide a placeholder in pull #633, by now the placeholder is gone.

This became an issue #670

The simplest was to update the reporting to reflect this change in the instrumenter API. Namely, I added a placeholder into the metadata array when the single if branch with no else condition.

I'd fix the design but that's already taking hours to reason about the various fails I could cause.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple questions, thanks for the patch.

@bcoe
Copy link
Member

bcoe commented Jul 5, 2022

@adrian-burlacu-software what's the state of this PR? I'm hesitant to land if it requires that we modify an existing regression test. But, since you wrote the regression test, you'd know better than me whether we should land.

@adrian-burlacu-software
Copy link
Contributor Author

adrian-burlacu-software commented Jul 9, 2022

@adrian-burlacu-software what's the state of this PR? I'm hesitant to land if it requires that we modify an existing regression test. But, since you wrote the regression test, you'd know better than me whether we should land.

@bcoe
I took another look at the files from pull #663 to resolve issue #649. It looks like I left out this placeholder in the test back then, meaning this should get landed.

The novelty for this level of integrity (with testing) to the project and the novelty of the project to me are the main problems here. Feels like some KISS design & testing would help, the Fast-Fuzz tool can now test entire projects, has been tested in practice, and I don't plan on making any more changes to it this year: https://www.npmjs.com/package/fast-fuzz

@bcoe bcoe changed the title Add placeholder to fix Implicit Else fix: add placeholder to fix Implicit Else Jul 13, 2022
@bcoe bcoe merged commit 0516f51 into istanbuljs:master Jul 13, 2022
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants