fix: Enable es-modules by default. #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous fix for istanbuljs#796 added an es-modules option and set it false by default. This default was a change of behavior in NYC as previously all sources were parsed as ES modules by the instrumenter. I believe the old behavior is the correct default because it allows NYC to work with modern code. Code which uses certain features which violate strict mode will have to disable es-modules. This will not effect ES5 which follows the rules of 'use strict'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous fix for #796 added an es-modules option and set it false by
default. This default was a change of behavior in NYC as previously all
sources were parsed as ES modules by the instrumenter. I believe the
old behavior is the correct default because it allows NYC to work with
modern code. Code which uses certain features which violate strict mode
will have to disable es-modules. This will not effect ES5 which follows
the rules of 'use strict'.