Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable es-modules by default. #889

Merged
merged 1 commit into from Jul 23, 2018
Merged

fix: Enable es-modules by default. #889

merged 1 commit into from Jul 23, 2018

Commits on Jul 12, 2018

  1. fix: Enable es-modules by default. 

    A previous fix for istanbuljs#796 added an es-modules option and set it false by
default.  This default was a change of behavior in NYC as previously all
sources were parsed as ES modules by the instrumenter.  I believe the
old behavior is the correct default because it allows NYC to work with
modern code.  Code which uses certain features which violate strict mode
will have to disable es-modules.  This will not effect ES5 which follows
the rules of 'use strict'.
    @coreyfarrell
    coreyfarrell committed Jul 12, 2018
    Copy the full SHA
    7a47836 View commit details
    Browse the repository at this point in the history