New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update description of how files are selected for instrumentation #1009
Conversation
Sync repo
Bring fork up to date
test: stop using LAZY_LOAD_COUNT (istanbuljs#960)
Get latest
Get latest
Get Latest
An attempt to clarify the behaviour of the options related to selecting the files to be covered by nyc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thank you so much @AndrewFinlay! Some minor nits and suggestions for you.
Also I think we can save some CI cycles if you just put [skip ci]
in your commit messages :)
Last thing, what do you think of doing newlines at the end of sentences rather than the arbitrary line length? I think it makes reviewing changes a bit easier since each line is a sentence but I know there's this (IMO strange) pattern in place - maybe there's a good reason for it I don't know but I'm not a fan personally...
@JaKXz thanks for the review, I'll add the [skip ci] in future, simply didn't know it existed. The line endings are simply an artefact of how I work with my editor. I'll fix it up tomorrow |
This is odd... the single newlines are being rendered as |
@JaKXz where are you seeing this? |
@coreyfarrell in the rich diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @AndrewFinlay!
So I've put together a draft to better explain how files are included for coverage in nyc.
Take a look and tell me what you think, it probably needs a few changes here or there but I think it will take out a little of the mystery in configuring nyc.