Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid hardcoded HOME for spawn-wrap working dir #957

Merged
merged 1 commit into from Jan 15, 2019

Commits on Jan 15, 2019

  1. feat: avoid hardcoded HOME for spawn-wrap working dir

    By default, spawn-wrap writes temporary files to HOME.
    It used to be /tmp, but it changed that to HOME to support
    environments that have 'noexec' flags set on their tmpfs mount.
    Ref istanbuljs/spawn-wrap#3.
    
    The problem with this is that nyc now no longer works in environments
    without a (writable) home directory (e.g. the 'nobody' user on
    Linux).
    
    While it is fine to fallback to HOME, it should write elsewhere
    if that is unavailable, and ideally in a way that doesn't require
    every sysadmin or end-user to hardcode some environment variable
    in their package.json specifically for nyc or spawn-wrap.
    
    A common way to communicate this intent is with the XDG_CACHE_HOME
    environment variable.
    
    Fixes istanbuljs#951.
    Krinkle committed Jan 15, 2019
    Copy the full SHA
    95bc8ee View commit details
    Browse the repository at this point in the history