fix(win32): handle cases where "node" is quoted #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue which was triggered by npm v6.11, where the "program" referenced by a shimmed shebang is always quoted (whereas before, it would not be). Ironically, the code change in npm was to work around cases where a user puts `"jslint"` in a batch file, resulting in the wrong %~dp0 being loaded. The fix triggered the same behavior in NYC, and the same fix resolves the problem here. For arcane and mysterious reasons, calling a subroutine in a batch file causes the %~dp0 variable to be set properly.
coreyfarrell
pushed a commit
to coreyfarrell/spawn-wrap
that referenced
this pull request
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue which was triggered by npm v6.11, where the
"program" referenced by a shimmed shebang is always quoted (whereas
before, it would not be). Ironically, the code change in npm was to
work around cases where a user puts
"jslint"in a batch file,resulting in the wrong %~dp0 being loaded. The fix triggered the same
behavior in NYC, and the same fix resolves the problem here.
For arcane and mysterious reasons, calling a subroutine in a batch file
causes the %~dp0 variable to be set properly.