Update to latest Prometheus to grab critical fix #10321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-reid
requested review from
mandarjog
and removed request for
myidpt and
rshriram
|
lint error completely unrelated to this PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, mandarjog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
philipgough
added a commit
to 3scale/3scale-istio-adapter
that referenced
this pull request
Jan 17, 2019
Adds an override to prometheus client version to avoid us pulling from master for 1.0.5. See istio/istio#10321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in: #10236, the Prometheus client_golang library has been patched to address a critical (for Istio) issue.
This PR updates our dep to
masterand the commit that contains the fix. There is a pending0.9.2release for Prometheus, but as 1.0.5 is about to released, I wanted to go ahead and unblock that release push.