Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gateway api to 0.8.0 #46773

Merged
merged 1 commit into from Aug 30, 2023
Merged

Conversation

jwendell
Copy link
Member

No description provided.

@jwendell jwendell added the release-notes-none Indicates a PR that does not require release notes. label Aug 30, 2023
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I thought we need kubernetes-sigs/controller-runtime#2460.

Nice work if you found a way around it!

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2023
@jwendell
Copy link
Member Author

/retest

@jwendell jwendell requested a review from a team as a code owner August 30, 2023 20:09
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TBH I don't get how it works but awesome

@istio-testing istio-testing merged commit 90b1e2d into istio:master Aug 30, 2023
27 checks passed
@keithmattix
Copy link
Contributor

Do we need to cherry-pick this?

@howardjohn
Copy link
Member

howardjohn commented Aug 30, 2023 via email

@ericvn
Copy link
Contributor

ericvn commented Aug 31, 2023

Do we need to cherry-pick this?

I have a PR that already was doing rc2 so updating with these changes: #46677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants