-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX of WindowCovering
by using motor_state
#854
base: master
Are you sure you want to change the base?
Conversation
@itavero What about utilizing So we're only updating All other devices however, would be stuck with the current implementation. Another relevant PR has been merged: Koenkk/zigbee-herdsman-converters#7470 |
WindowCovering
with Bosch BCMT-SLZWindowCovering
by using motor_state
@itavero Did you already had time to take a look at the PR? |
Unfortunately I have not had time. Hopefully I can find a moment this week to do at least a quick check, but my schedule is still quite busy. |
Don't worry. 😊 |
@itavero Would appreciate if you can already run the two workflows, so I can make any necessary changes in due time. ✌️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 66.17% 64.03% -2.14%
==========================================
Files 40 40
Lines 2903 2550 -353
Branches 792 619 -173
==========================================
- Hits 1921 1633 -288
- Misses 883 910 +27
+ Partials 99 7 -92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@itavero Alright, I've completely reworked how we're checking for the presence of |
Should probably also mention this in the changelog and the docs for the window covering, but I can also do that before merging the code. |
@itavero Implemented the changes you've suggested. Based on my testing, everything still works! 😅 |
@itavero I've been dog-fooding this PR for the past few days, and it's working quite nicely. So from my side, we should be ready for takeoff. 🛫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a glance at the other changes and they seem fine. Hopefully I'll have time to do a proper review in the next few days and get this thing merged.
Sonarcloud is also complaining about the complexity of scaleAndUpdateCurrentPosition
, but I think I can live with that for now.
Quality Gate passedIssues Measures |
🆗 Published SonarCloud and code coverage data. |
@itavero Alright, our robot overlords 🤖 should now be pleased. 😅 |
Implements support for the optional
motor_state
attribute exposed by some coverings, while keeping the current behavior for all others.📌 Unfortunately, it's not really feasible to improve HAP compliance for devices that do not support
motor_state
, without removing features.Fixes #852