Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: dogfood & tidy #1165

Merged
merged 6 commits into from
Sep 22, 2022
Merged

workflow: dogfood & tidy #1165

merged 6 commits into from
Sep 22, 2022

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Sep 12, 2022

  • minify/tidy/lint workflows
  • bump actions versions
  • CML dogfooding
  • make releases --draft

@casperdcl casperdcl added technical-debt Refactoring, linting & tidying testing Unit tests & debugging deployment releases Shipping builds labels Sep 12, 2022
@casperdcl casperdcl self-assigned this Sep 12, 2022
@casperdcl casperdcl temporarily deployed to internal September 12, 2022 22:32 Inactive
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally not a fan of the {} syntax in yaml, additionally its even less commonly seen in the scope of GitHub Actions.

.github/workflows/images.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/test-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/trigger-external.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@0x2b3bfa0
Copy link
Member

I am personally not a fan of the {} syntax

I wholeheartedly agree: it's :purugly:

@casperdcl casperdcl temporarily deployed to internal September 13, 2022 10:46 Inactive
@casperdcl
Copy link
Contributor Author

personally not a fan of the {} syntax

-Wnot-using-a-legitimate-feature? This syntax exists for precisely this use case (short one-liner unlikely to change).

less commonly seen in the scope of GitHub Actions

fallacious, scanadlous!

@0x2b3bfa0
Copy link
Member

-Wnot-using-a-legitimate-feature

For the same reason some code files contain line breaks, even if they don't have to: readability.

@casperdcl
Copy link
Contributor Author

For the same reason some code files contain line breaks

Still not right - an accurate analogy would be refusing to use line breaks. Refusing to use a feature regardless of scenario is inexplicable.

readability

yes, maximising that here. Also not using {} where it doesn't make sense/harms readability. Also the linter is v. happy with the proposed use of {} :)

@casperdcl casperdcl temporarily deployed to internal September 15, 2022 00:23 Inactive
@tasdomas
Copy link
Contributor

Re {} - that syntax has limited (very limited) uses in yaml, imho. Linters are not raising issues because valid json is valid yaml.

@casperdcl casperdcl temporarily deployed to internal September 22, 2022 12:28 Inactive
@casperdcl
Copy link
Contributor Author

casperdcl commented Sep 22, 2022

dropped {} by popular demand

Also pushed some docstring edits after a thorough review (related to iterative/cml.dev#324) - please do check /CC @0x2b3bfa0 will move to separate PR

@casperdcl casperdcl temporarily deployed to internal September 22, 2022 12:33 Inactive
@casperdcl casperdcl mentioned this pull request Sep 22, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 22, 2022 13:55 Inactive
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤺 🤝

@0x2b3bfa0 0x2b3bfa0 merged commit bee8192 into master Sep 22, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the workflow-tidy branch September 22, 2022 14:14
This was referenced Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases Shipping builds technical-debt Refactoring, linting & tidying testing Unit tests & debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants