misc fixes & linting #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
casperdcl
commented
May 13, 2021
•
casperdcl
commented
- update README
- remove & update outdated info
- misc tidy
- add cross-references
- fix image
- update & simplify workflows
- enable Windows tests
- lint YAML
- rebuild
- fix checks (use local action, restyled config)
- fix Ubuntu 18.04 install
- document deps at https://github.com/iterative/cml#install-cml-as-a-package?
- update & fix version checks (don't require a token when not needed cml#515)
- related: lint & rebuild setup-dvc#18
- depends on windows bugfix Fix pipe reading logic on Windows cml#516 (well, actually found the bug)
- fix checks (use local action, restyled config) - update names - lint YAML - rebuild
casperdcl
added
p0-critical
- related iterative/setup-dvc#21
casperdcl
commented
May 13, 2021
|
oh come on 🌬️ 🚪 🚪 |
|
Note: iterative/cml#516 was merged and released yesterday |
Closed
casperdcl
force-pushed
the
misc-updates
branch
4 times, most recently
from
15ffcb6
to
29df0dc
Compare
casperdcl
commented
Jun 14, 2021
| apt -y update && apt install -y git | ||
|
|
||
| apt update -y | ||
| apt install -y git fontconfig make gcc pkg-config |
There was a problem hiding this comment.
should we document these deps?
There was a problem hiding this comment.
alternatively we could add this to the action itself?
There was a problem hiding this comment.
They're there just because the Ubuntu Docker images are really bare-bones and doesn't include them. We can include them in the action, but that would imply including operating system checks. What if users choose a container with Alpine Linux? 🤔
There was a problem hiding this comment.
It would be safer to either ignore or document them.
- reduce cross-repo duplication and outdated info - add cross-references
0x2b3bfa0
reviewed
Jun 14, 2021
casperdcl
commented
Jun 14, 2021
casperdcl
commented
Jun 14, 2021
0x2b3bfa0
reviewed
Jun 15, 2021
0x2b3bfa0
reviewed
Jun 15, 2021
| steps: | ||
| - name: "git" | ||
| if: "fromJSON(matrix.runs-on).container == 'ubuntu:18.04'" | ||
| - name: install deps |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
0x2b3bfa0
requested changes
Jun 15, 2021
0x2b3bfa0
approved these changes
Jun 16, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.