Optimize startup on versionLessThan function #2979
Merged
+104
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wtf error? |
felipepasc
changed the title
itzg
reviewed
Jul 10, 2024
|
I had gotten a weird Docker error, so I just added a space to run it again and it worked, I changed it to the version variable to check |
itzg
approved these changes
Jul 11, 2024
|
From my tests on my dedicated device, before the change, the startup message took around 17 seconds to arrive, after the change it dropped to 7 seconds |
|
This number may not be the same for everyone, some will feel the changes more and others less depending on the CPU and especially the speed of the ra memory. |
|
But everything is ok now I believe |
sevenrats
pushed a commit
to sevenrats/docker-minecraft-server
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, how are you? I've been using the lib for a few months now, but I notice a slowdown when trying to start, and when analyzing and testing I realized that most of it is because of the versionLessThan function, so I redid it in bash script, did some tests and everything worked fine.