prettier#16147: do not format CDATA with angular parser

iuliaaai · Apr 29, 2024 · 3597494 · 3597494
1 parent 1264a4c
commit 3597494
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 0 deletions.
diff --git a/src/language-html/printer-html.js b/src/language-html/printer-html.js
@@ -68,6 +68,10 @@ function genericPrint(path, options, print) {
         printClosingTagEnd(node, options),
       ];
     case "text": {
+      // CDATA should not be formatted
+      if (node.value.startsWith("<![CDATA") && node.value.endsWith("]>") && options.parser === "angular") {
+        return node.value
+      }
       if (node.parent.type === "interpolation") {
         // replace the trailing literalline with hardline for better readability
         const trailingNewlineRegex = /\n[^\S\n]*$/;

diff --git a/tests/format/angular/cdata/__snapshots__/jsfmt.spec.js.snap b/tests/format/angular/cdata/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,19 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`example.html format 1`] = `
+====================================options=====================================
+parsers: ["angular"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+<![CDATA[<app-alert>
+  Lorem ipsum dolor sit amet consectetur adipisicing elit.
+</app-alert>]]>
+
+=====================================output=====================================
+<![CDATA[<app-alert>
+  Lorem ipsum dolor sit amet consectetur adipisicing elit.
+</app-alert>]]>
+
+================================================================================
+`;
diff --git a/tests/format/angular/cdata/example.html b/tests/format/angular/cdata/example.html
@@ -0,0 +1,3 @@
+<![CDATA[<app-alert>
+  Lorem ipsum dolor sit amet consectetur adipisicing elit.
+</app-alert>]]>
diff --git a/tests/format/angular/cdata/jsfmt.spec.js b/tests/format/angular/cdata/jsfmt.spec.js
@@ -0,0 +1 @@
+runFormatTest(import.meta, ["angular"]);