Add optional copying of Exif metadata to the output image / base64 data #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to androidx for back compatibility with older android versions - Include all supported Exif tags - Add copyExif parameter to copy Exif data to output image - Ensure orientation/size are correct for output image - Get base64 data _after_ output image is generated so that it contains correct Exif data Co-authored-by: Jake Gough <super.jake@hotmail.co.uk>
- Rename exif to metadata (avoid confusion with actual 'Exif' key of metadata) - Add copyExif parameter to copy Exif data to output image - Ensure orientation/size are correct for output image - Get metadata before compressing image Co-authored-by: Jake Gough <super.jake@hotmail.co.uk>
Co-authored-by: Jake Gough <super.jake@hotmail.co.uk>
|
@ivpusic can we get this merged, super helpful feature! |
|
@mjmasn should update README with the new copyExif property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this project is accepting PRs but thought it was worth sharing some changes @soupjake and I had worked on to support copying Exif metadata to the output of this library.
Happy to make any changes necessary, I'm not much of an iOS developer so would be good for someone who knows what they're doing to give this a once over.
One caveat is that this doesn't work for cropped images on iOS (we didn't dig further into that as we're not using cropping ourselves)