feat: Add "any" mediaType support for openCamera on iOS #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
changed the title
|
@ivpusic could you please review this? |
|
@gabrieldonadel how can i import your lib |
You can patch react-native-image-crop-picker and apply these changes manually using patch-package |
|
@gabrieldonadel I'm assuming patch-package is the only way to get this change in considering this didn't make to an official release? |
Yeah @mxbm, unfortunately @ivpusic has not reviewed this yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for the
anymediaType when using theopenCamerafunction on iOS, allowing users to either take a picture or record a video. Unfortunately with the current approach, there's no way to add support for theanymediaType on Android, as we use different intents depending on the selected media type and android does not have an intent that supports both taking images and recording videos.