Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docutils from 0.17.1 to 0.18.1 in /requirements #248

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2022

Bumps docutils from 0.17.1 to 0.18.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@gitpod-io
Copy link

gitpod-io bot commented Jul 1, 2022

@jab
Copy link
Owner

jab commented Jul 1, 2022

Upgrading docutils is currently blocked on sphinx-doc/sphinx#10531 (as the comment says in requirements/docs.in). Leaving this PR open as a reminder to upgrade (and remove the pin) once the issue blocking this is fixed.

(This may also be blocked on changes in Furo, but AFAIK a tracking issue in Furo has not yet been created that we can link to / watch. CC @pradyunsg)

@pradyunsg
Copy link

There’s nothing preventing a build from Furo’s end strictly — footnotes look slightly different, which… is fine?

@jab
Copy link
Owner

jab commented Jul 2, 2022

Thanks for the quick reply, @pradyunsg!

Rather than "footnotes look slightly different", I think it'd be more accurate to say "footnotes look broken". Please take another peek at the "before" and "after" screenshots I posted in pradyunsg/furo#452 to see what I mean. Not only are footnotes no longer appearing on the same line as their corresponding footnote numbers, but worse, they're not even being indented consistently: Note how footnote 3 in the "after" screenshot is inexplicably not indented, while footnotes 1, 2, and 4 are indented. Based on this example, would you agree this goes beyond looking slightly different and really reaches "looking broken" territory?

If so, then I assume that additional changes would be necessary in Furo to fix this. But since I haven't been able to dig too deeply into this bug, maybe that's not actually true?

Thanks again for taking a look at this.

Bumps [docutils](http://docutils.sourceforge.net/) from 0.17.1 to 0.18.1.

---
updated-dependencies:
- dependency-name: docutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/requirements/docutils-0.18.1 branch from 047ece3 to 28707b6 Compare July 3, 2022 15:34
Repository owner deleted a comment from codecov bot Jul 6, 2022
@jab
Copy link
Owner

jab commented Jul 6, 2022

Quoting https://sourceforge.net/p/docutils/bugs/450/?page=1#0624

Fixed in Docutils 0.19.

Great to see the fix has been released! @pradyunsg, does this help with testing any potentially required followup changes to Furo?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 6, 2022

Looks like docutils is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Aug 6, 2022
@dependabot dependabot bot deleted the dependabot/pip/requirements/docutils-0.18.1 branch August 6, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants