[WIP] Observation #241
Open
[WIP] Observation #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,10 +127,12 @@ public function __construct(FactoryInterface $factory, Repository $repository, $ | |||
| { | |||
| $this->factory = $factory; | |||
| $this->repository = $repository; | |||
| $this->objectManager = $this->factory->get('ObjectManager', array($transport, $this)); | |||
| $observationManager = $this->factory->get('Observation\ObservationManager', array($factory, $this, $transport)); | |||
| $this->objectManager = $this->factory->get('ObjectManager', array($transport, $this, $observationManager)); | |||
There was a problem hiding this comment.
Observation manager is always created when the session is intantiated.
|
what do you mean by non-journaling? that we only see the events of the current session? i agree it should go into jackalope/jackalope. just make sure its done in a way that jackalope-jackrabbit can do everything differently. |
|
yeah. so repositories can support "non journaling", journaling or both. Non-journaling would be the equivalent of the SF event system I think. http://www.day.com/specs/jcr/2.0/12_Observation.html#12.1%20Event%20Model |
|
can we reuse the symfony event component for this? |
|
We could wrap it I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on Observation this morning. Basically the goal of this PR is to support non-journaling event observation.
I guess this can all be done at the jackalope level?