[WIP] improve performance for loading the standard node types #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,22 +100,29 @@ public function __construct( | |||
| * | |||
| * On fetch all, already cached node types are kept. | |||
| * | |||
| * @param string $name type name to fetch. defaults to null which will | |||
| * @param array $name type name to fetch. defaults to null which will | |||
|
there is #342 which improves for user node types. pavel claims that the speed for standard node types is very high on php 7 - should we just drop these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also requires changes in the transports
essentially the issue is that loading the standard node types is super slow, yet we load these everytime we run a query with the doctrine dbal transport