Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Versioning #296

Open
wants to merge 15 commits into
base: 2.x
Choose a base branch
from
Open

[WIP] Versioning #296

wants to merge 15 commits into from

Conversation

dbu
Copy link
Member

@dbu dbu commented Aug 16, 2015

Main PR that will add the wrapped up work of @danrot to master.

@ni-meilhard
Copy link

Hi there,
Is there any intention to merge this PR in future?
Thanks!

@dbu
Copy link
Member Author

dbu commented Oct 25, 2021

currently versioning is supported with jackalope-jackrabbit by leveraging jackrabbit features for doing the versioning operations.

i have no plan to work on this, but if somebody wants to pick it up i am happy to review a merge request. i don't know how complete & bug free the PR is at this point. it should at least be tested with jackalope/jackalope-doctrine-dbal#316 to know if it works.

ideally, the phpcr-api-tests are also challenged to check if they cover all relevant versioning situations.

@mortis0
Copy link

mortis0 commented Feb 7, 2024

Hello, in case one day this MR is picked up, there is a typo in VersionHandler.php line 224 "$frozenNode->hasProperty" should be "$node->hasProperty" and on line 225 "$node->getProperty('jcr:mixinTypes')" should be "$node->getProperty('jcr:mixinTypes')->getValue()"
Minor that, the versionning works fine for me with an XtraDB 8, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants