-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Versioning #296
base: 2.x
Are you sure you want to change the base?
[WIP] Versioning #296
Conversation
Hi there, |
currently versioning is supported with jackalope-jackrabbit by leveraging jackrabbit features for doing the versioning operations. i have no plan to work on this, but if somebody wants to pick it up i am happy to review a merge request. i don't know how complete & bug free the PR is at this point. it should at least be tested with jackalope/jackalope-doctrine-dbal#316 to know if it works. ideally, the phpcr-api-tests are also challenged to check if they cover all relevant versioning situations. |
Hello, in case one day this MR is picked up, there is a typo in VersionHandler.php line 224 "$frozenNode->hasProperty" should be "$node->hasProperty" and on line 225 "$node->getProperty('jcr:mixinTypes')" should be "$node->getProperty('jcr:mixinTypes')->getValue()" |
Main PR that will add the wrapped up work of @danrot to master.