Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ASM to 9.7 #1600

Merged
merged 3 commits into from Mar 25, 2024
Merged

Upgrade ASM to 9.7 #1600

merged 3 commits into from Mar 25, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Mar 24, 2024

Fixes #1599

@merks
Copy link
Contributor Author

merks commented Mar 24, 2024

@marchof @Godin

I tried to reproduce the corresponding changes for this PR that I saw for the following PR's changes for upgrading from 9.5 to 9.6:

#1518

Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @merks here at the JaCoCo project! Looks good to me except the change log entry.

org.jacoco.doc/docroot/doc/changes.html Outdated Show resolved Hide resolved
@Godin Godin added this to the 0.8.12 milestone Mar 25, 2024
@Godin Godin added this to Implementation in Current work items via automation Mar 25, 2024
@Godin Godin self-assigned this Mar 25, 2024
@merks
Copy link
Contributor Author

merks commented Mar 25, 2024

Thanks guys! I'll try to get the PR fully correct the next time...

@merks
Copy link
Contributor Author

merks commented Mar 25, 2024

If the link is to the PR rather than the issue, it's not actually possible to get it right until one first creates the PR. Of course typically it's the issue +1, but I'm not sure that this is always the case. Anyway, just thinking of the process the next time this comes up...

@Godin
Copy link
Member

Godin commented Mar 25, 2024

I'll try to get the PR fully correct the next time

Thanks for this PR ❤️ And no worries - slight polishing by us is not a big deal 👐

Previously we've been quite proactive with ASM updates thanks to a subscription to their mailing list, but seems that they haven't done announcements for the past two versions 😞

it's not actually possible to get it right until one first creates the PR

Usually changelog modification is the very last commit and PR is first opened without this modification 😉

but I'm not sure that this is always the case

You have to believe me that this is true for the existing entries or at least for the majority.

Copy link
Member

@Godin Godin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record
here is a link to their changelog - https://asm.ow2.io/versions.html
and actual changes between versions - https://gitlab.ow2.org/asm/asm/-/compare/ASM_9_6...ASM_9_7

From this to me seems that this time there were no changes that could negatively impact us.

@@ -1,7 +1,7 @@
<h4>ASM</h4>

<p>
<a href="https://asm.ow2.io/">ASM 9.6</a> is subject to the terms and
<a href="https://asm.ow2.io/">ASM 9.7</a> is subject to the terms and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did check that their license stayed unchanged.

@Godin Godin merged commit 40ff9fb into jacoco:master Mar 25, 2024
28 checks passed
Current work items automation moved this from Implementation to Done Mar 25, 2024
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Apr 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `2.0.3` -> `2.0.4` |
| [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | compile | minor | `2.15.1` -> `2.16.1` |
| [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.11` -> `0.8.12` |
| [com.google.guava:guava](https://github.com/google/guava) | compile | minor | `33.0.0-jre` -> `33.1.0-jre` |
| [org.codehaus.janino:janino](http://janino-compiler.github.io/janino/) ([source](https://github.com/janino-compiler/janino)) | compile | patch | `3.1.11` -> `3.1.12` |
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.3` -> `3.2.5` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary>

### [`v2.0.4`](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE)

[Compare Source](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE)

</details>

<details>
<summary>jacoco/jacoco (org.jacoco:jacoco-maven-plugin)</summary>

### [`v0.8.12`](https://github.com/jacoco/jacoco/releases/tag/v0.8.12): 0.8.12

[Compare Source](jacoco/jacoco@v0.8.11...v0.8.12)

#### New Features

-   JaCoCo now officially supports Java 22 (GitHub [#&#8203;1596](jacoco/jacoco#1596)).
-   Experimental support for Java 23 class files (GitHub [#&#8203;1553](jacoco/jacoco#1553)).

#### Fixed bugs

-   Branches added by the Kotlin compiler for functions with default arguments and having more than 32 parameters are filtered out during generation of report (GitHub [#&#8203;1556](jacoco/jacoco#1556)).
-   Branch added by the Kotlin compiler version 1.5.0 and above for reading from lateinit property is filtered out during generation of report (GitHub [#&#8203;1568](jacoco/jacoco#1568)).

#### Non-functional Changes

-   JaCoCo now depends on ASM 9.7 (GitHub [#&#8203;1600](jacoco/jacoco#1600)).

</details>

<details>
<summary>janino-compiler/janino (org.codehaus.janino:janino)</summary>

### [`v3.1.12`](janino-compiler/janino@v3.1.11...v3.1.12)

[Compare Source](janino-compiler/janino@v3.1.11...v3.1.12)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Update to ASM 9.7
3 participants