New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ASM to 9.7 #1600
Upgrade ASM to 9.7 #1600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @merks here at the JaCoCo project! Looks good to me except the change log entry.
Thanks guys! I'll try to get the PR fully correct the next time... |
If the link is to the PR rather than the issue, it's not actually possible to get it right until one first creates the PR. Of course typically it's the issue +1, but I'm not sure that this is always the case. Anyway, just thinking of the process the next time this comes up... |
Thanks for this PR ❤️ And no worries - slight polishing by us is not a big deal 👐 Previously we've been quite proactive with ASM updates thanks to a subscription to their mailing list, but seems that they haven't done announcements for the past two versions 😞
Usually changelog modification is the very last commit and PR is first opened without this modification 😉
You have to believe me that this is true for the existing entries or at least for the majority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record
here is a link to their changelog - https://asm.ow2.io/versions.html
and actual changes between versions - https://gitlab.ow2.org/asm/asm/-/compare/ASM_9_6...ASM_9_7
From this to me seems that this time there were no changes that could negatively impact us.
@@ -1,7 +1,7 @@ | |||
<h4>ASM</h4> | |||
|
|||
<p> | |||
<a href="https://asm.ow2.io/">ASM 9.6</a> is subject to the terms and | |||
<a href="https://asm.ow2.io/">ASM 9.7</a> is subject to the terms and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check that their license stayed unchanged.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `2.0.3` -> `2.0.4` | | [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | compile | minor | `2.15.1` -> `2.16.1` | | [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.11` -> `0.8.12` | | [com.google.guava:guava](https://github.com/google/guava) | compile | minor | `33.0.0-jre` -> `33.1.0-jre` | | [org.codehaus.janino:janino](http://janino-compiler.github.io/janino/) ([source](https://github.com/janino-compiler/janino)) | compile | patch | `3.1.11` -> `3.1.12` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.3` -> `3.2.5` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v2.0.4`](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE) [Compare Source](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE) </details> <details> <summary>jacoco/jacoco (org.jacoco:jacoco-maven-plugin)</summary> ### [`v0.8.12`](https://github.com/jacoco/jacoco/releases/tag/v0.8.12): 0.8.12 [Compare Source](jacoco/jacoco@v0.8.11...v0.8.12) #### New Features - JaCoCo now officially supports Java 22 (GitHub [#​1596](jacoco/jacoco#1596)). - Experimental support for Java 23 class files (GitHub [#​1553](jacoco/jacoco#1553)). #### Fixed bugs - Branches added by the Kotlin compiler for functions with default arguments and having more than 32 parameters are filtered out during generation of report (GitHub [#​1556](jacoco/jacoco#1556)). - Branch added by the Kotlin compiler version 1.5.0 and above for reading from lateinit property is filtered out during generation of report (GitHub [#​1568](jacoco/jacoco#1568)). #### Non-functional Changes - JaCoCo now depends on ASM 9.7 (GitHub [#​1600](jacoco/jacoco#1600)). </details> <details> <summary>janino-compiler/janino (org.codehaus.janino:janino)</summary> ### [`v3.1.12`](janino-compiler/janino@v3.1.11...v3.1.12) [Compare Source](janino-compiler/janino@v3.1.11...v3.1.12) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge...
Fixes #1599