[jaeger-operator] Enforce default container security context #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majidazimi
changed the title
|
lint-test stage has failed without a clear error message: |
I saw similar failures on the job for jaeger helm chart PR's. Pod is failing to be scheduled because node has a taint. |
Signed-off-by: Majid Azimi <s.azimigehraz@reply.de>
Signed-off-by: Majid Azimi <s.azimigehraz@reply.de>
|
I fixed the version conflict by bumping chart version. Would you please take a look into this? |
chgl
reviewed
Aug 5, 2021
| @@ -36,6 +36,11 @@ spec: | |||
| - name: {{ include "jaeger-operator.fullname" . }} | |||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | |||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | |||
| securityContext: | |||
There was a problem hiding this comment.
If you don't mind a small comment: I personally prefer the flexibility of setting the entire securityContext via values.yaml, e.g.:
# values.yaml:
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
privileged: false
runAsUser: 65532with deployment.yaml being:
securityContext:
{{- toYaml .securityContext | nindent 12 }}There was a problem hiding this comment.
Sure. However, since there is already securityContext at pod level, it would be better to add containerSecurityContext in values.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since upstream docker image is already using non root user, I thought it might be good to enforce security context at container level in the chart to prevent accidental problems.
Does it make sense to make this configurable? jaeger-operator will always run under non root and it will not modify local file system anyways. So I hardcoded all the parameters.