[Feature] change the default layout selection for deep dependency graph view (view=ddg) #600
Comments
|
I don't have a strong opinion on the specific default itself, but I think it would be useful to have it configurable per installation in the ui config, so that the change is backwards compatible in case some people really like the current default. |
|
@yurishkuro yeah it would be nice to be configurable as part of ui deployment. |
|
can I work on this issue? |
|
@Leena1666 it's yours! |
|
I am aware that this issue has already been assigned, but I did it nevertheless given that it was assigned almost 6 months ago. Do let me know if I should close my PR. |
yurishkuro
changed the title
|
@yurishkuro, Is this issue still open? I would like to work on it! |
|
It's open |
|
I had a question regarding this issue, the default option should not be set to One Node per resource, but rather the default option should be configurable as per the User right? |
|
It should be configurable by user, but in the absence of such configuration it should behave the same as today. |
|
Understood! Thanks for clarifying! |
|
Hi, I thought configurable by user meant that the end user can set any of the option as defualt and was thinking of adding set as default as an additional option and had made the required changes for that, and was about to raise a PR but then I took a look at the below Thread: #891 and found out there are some entirely different expectations and I have misunderstood them something to do with the below picture |
I think there's even a simpler solution - store last used option in local storage and apply it on new screens. Changing default via configuration would be next level, very high friction for small benefit. |
|
Got it thanks a lot! Will implement that itself |
## Problem Resolves #600, which reported a concern related to [Feature] change the default layout selection for deep dependency graph view (view=ddg) ## Changes In order to resolve the mentioned issue, the following changes have been implemented: - Implemented logic in the componentDidMount lifecycle method to check local storage for a previously selected density, setting it as the default if found. - Modified the updateDensity method to save the selected density in local storage, ensuring persistence across sessions. - Enhanced user experience by retaining and applying the last selected density even after page reloads. ## Testing The changes have been thoroughly tested to ensure their correctness and compatibility. The testing process included: - Modifying the index.test.js, to also consider a default configuration from local storage, rather than only considering a fixed configuration for testing. ## Checklist To comply with the project's contribution guidelines, the following checklist items have been addressed: - ✓ I have carefully read and followed the [contributing guidelines](https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md). - ✓ I have signed all commits. - ✓ Unit tests for the new functionality have been added. - ✓ Linting and testing steps have been successfully executed: - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test`  --------- Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com> Signed-off-by: Saransh Shankar <103821431+Wise-Wizard@users.noreply.github.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <github@ysh.us>
Requirement - what kind of business use case are you trying to solve?
can we change the default choice of
layout selectionto beone node per resourcein this section:Current default is
show paths to focal nodeThe text was updated successfully, but these errors were encountered: