Use One node per resource as default option

[PawBud]

Which problem is this PR solving?

• Resolves [Feature] change the default layout selection for deep dependency graph view (view=ddg) #600

Short description of the changes

• the default option for graph density has been replaced with One node per resource

2022-02-24.00-45-08.mp4

[yurishkuro]

It was stated in the ticket that we cannot just change the default, instead we can add a config option to control what default to use.

[PawBud]

It was stated in the ticket that we cannot just change the default, instead we can add a config option to control what default to use.

Oops, I misread it, Thanks a lot for pointing it out. I'll issue a commit adding that feature.

[PawBud]

It was stated in the ticket that we cannot just change the default, instead we can add a config option to control what default to use.

Felt like a dropdown would be much more minimalistic, thoughts @yurishkuro?

[yurishkuro]

If you're suggesting to remove descriptions from the drop down than I would be against it, it would make usability worse.

[PawBud]

If you're suggesting to remove descriptions from the drop down than I would be against it, it would make usability worse.

I was actually asking about the UI to keep a graph density option as default? like the UI of the config to achieve that.
@yurishkuro

Do we keep a dropdown to do that, or a redundant set as default checkbox after every density option? or something else?

[yurishkuro]

Sorry, I don't follow. We don't want to change the default, only to allow it to be configurable.

[PawBud]

Sorry, I don't follow. We don't want to change the default, only to allow it to be configurable.

Yes which basically means that the user should choose what the default option should be, right? @yurishkuro

[yurishkuro]

not the end user of the UI, but the operator of Jaeger installation: https://www.jaegertracing.io/docs/1.31/frontend-ui/#configuration

[PawBud]

not the end user of the UI, but the operator of Jaeger installation: https://www.jaegertracing.io/docs/1.31/frontend-ui/#configuration

Got it, Thanks a lot for clarifying!

[PawBud]

@yurishkuro I need to add a "setDefaultOption" for the UI config https://github.com/jaegertracing/jaeger-ui/blob/main/packages/jaeger-ui/src/types/config.tsx#L41-L66 ?

[yurishkuro]

yes

  deepDependencies?: {
    menuEnabled?: boolean;
    defaultDisplayMode: ...
  };

[PawBud]

yes

  deepDependencies?: {
    menuEnabled?: boolean;
    defaultDisplayMode: ...
  };

I am having trouble writing the tests, can you help me? @yurishkuro

[yurishkuro]

Sorry, I'm not a UI dev. Don't we have existing tests to model after?

[PawBud]

Let me have a proper look, will get back to u soon