Fix time calculation in Trace Graph view #1920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves jaegertracing#1918 Now the total duration is calculating as the duration of the union of spans. Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
yurishkuro
reviewed
Oct 30, 2023
| mdr.add(m.span.startTime, m.span.startTime + (m.span.duration <= 0 ? 0 : m.span.duration - 1)), | ||
| new DRange() | ||
| ).length; | ||
| const totalTime = node.members.reduce((p, m) => p + m.span.duration, 0); |
There was a problem hiding this comment.
@GLVSKiriti this sounds similar to the other fix you made in another view. Is there a way to consolidate these calculations?
There was a problem hiding this comment.
I don't know exactly but I will take a look on this!
There was a problem hiding this comment.
Can we push it? The change is relatively small but fixes self-time and total time calculation bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test