New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure max received message size for jaeger-query #4351
base: main
Are you sure you want to change the base?
Conversation
2f6df6e
to
9d94b7d
Compare
@ChillOrb the argument interpretation is copied from the equivalent option in collector |
Looking at this a bit more, I found that currently grpc-go only supports As for the following variable name @yurishkuro What do you think? |
Go API calls is "size", which is what we call it too. "length" is from some other documentation. |
any follow-up? |
9d94b7d
to
8da3ed8
Compare
8da3ed8
to
6896a5b
Compare
…rage plugin Signed-off-by: Chan Kwan Yin <chankyin@bytedance.com>
6896a5b
to
218f9cc
Compare
Rewrote the commit, changing the grpc storage instad of the query command. |
@@ -73,5 +75,6 @@ func (opt *Options) InitFromViper(v *viper.Viper) error { | |||
} | |||
opt.Configuration.RemoteConnectTimeout = v.GetDuration(remoteConnectionTimeout) | |||
opt.Configuration.TenancyOpts = tenancy.InitFromViper(v) | |||
opt.Configuration.MaxRecvMsgSize = v.GetInt(grpcMaxRecvMsgSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add to tests
Currently this option only exists for collector but not for query.
This option is required when a storage returns a very large grpc message (>4MiB).
Which problem is this PR solving?
Short description of the changes
--grpc-storage.max-recv-msg-size
option.